-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Commit Classification Rule #392
Closed
lauraschauer
wants to merge
33
commits into
SAP:main
from
lauraschauer:lascha-commit-classification-rule
Closed
Adds Commit Classification Rule #392
lauraschauer
wants to merge
33
commits into
SAP:main
from
lauraschauer:lascha-commit-classification-rule
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lauraschauer
force-pushed
the
lascha-commit-classification-rule
branch
from
July 4, 2024 12:44
6d37089
to
e951f9b
Compare
…can be called with this model. This is because only one instantiation of the model is needed throughout the whole runtime of prospector
Problem to fix tomorrow: it takes all commits into consideration, but it should only take the 50 top ones or so
…e runs a set of rules, which can be invoked with the Phase's apply_rules() method
todo: add more tests
lauraschauer
force-pushed
the
lascha-commit-classification-rule
branch
2 times, most recently
from
July 5, 2024 12:06
f6606f0
to
d4bc29e
Compare
lauraschauer
force-pushed
the
lascha-commit-classification-rule
branch
from
July 5, 2024 12:08
d4bc29e
to
f15a5ad
Compare
I messed up rebasing, opening a new one so that the commits are in order and changes are clear. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new rule using the
LLMService
. This rule performs the same as Tommaso's commit classification, but is now implemented in Prospector itself.It sends the diff of a commit to the LLM and asks if this commit is security relevant or not. Relevance of the rule is set to 32 for now, but this value can be adjusted after evaluation.